fix(api): 404 when adding a term to a missing vocabulary (#22); log public 500s (#18)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-06-04 17:17:35 +02:00
parent fbb7a297a6
commit 2bce469ed2
3 changed files with 48 additions and 6 deletions
@@ -185,9 +185,15 @@ pub(crate) async fn add_term(
        .await
        .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;

-    let term_id = db::vocab::add_term(&mut tx, &new)
-        .await
-        .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)?;
+    let term_id = db::vocab::add_term(&mut tx, &new).await.map_err(|err| {
+        // A well-formed id for a missing vocabulary hits the FK constraint (23503).
+        if err.as_database_error().and_then(|e| e.code()).as_deref() == Some("23503") {
+            StatusCode::NOT_FOUND
+        } else {
+            tracing::error!(?err, "adding term");
+            StatusCode::INTERNAL_SERVER_ERROR
+        }
+    })?;

    tx.commit()
        .await