Log server errors on the public API 500 paths (wire tracing in the api crate) #18

New Issue

2026-06-02T12:06:18Z

logaritmisk commented

2026-06-02 12:06:18 +00:00

Context

The public API handlers (crates/api/src/public.rs) map db errors to 500 via .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR) / Err(_) => INTERNAL_SERVER_ERROR, discarding the underlying sqlx::Error. A 500 with no trace makes production debugging hard. The api crate currently has no tracing dependency (the server crate does).

What to do

Add tracing to the api crate.

Log the discarded error on every 500 path, e.g.:

.map_err(|err| { tracing::error!(?err, "db error listing public objects"); StatusCode::INTERNAL_SERVER_ERROR })

Apply consistently across list_objects and get_object (and future handlers).

References

crates/api/src/public.rs — list_objects, get_object
Surfaced by the Plan 7 Task 3 code-quality review.

## Context The public API handlers (`crates/api/src/public.rs`) map db errors to `500` via `.map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)` / `Err(_) => INTERNAL_SERVER_ERROR`, **discarding the underlying `sqlx::Error`**. A 500 with no trace makes production debugging hard. The `api` crate currently has no `tracing` dependency (the `server` crate does). ## What to do - Add `tracing` to the `api` crate. - Log the discarded error on every 500 path, e.g.: ```rust .map_err(|err| { tracing::error!(?err, "db error listing public objects"); StatusCode::INTERNAL_SERVER_ERROR }) ``` - Apply consistently across `list_objects` and `get_object` (and future handlers). ## References - `crates/api/src/public.rs` — `list_objects`, `get_object` - Surfaced by the Plan 7 Task 3 code-quality review.

logaritmisk commented

2026-06-02 21:02:13 +00:00

Scope note from the admin-CRUD work (merged main @ c4e0c4c): the new admin handlers follow the same pattern as the public surface — .map_err(|_| StatusCode::INTERNAL_SERVER_ERROR) with the underlying error discarded and no tracing. This affects crates/api/src/admin_objects.rs, admin_vocab.rs, and admin_authorities.rs. When wiring tracing, cover the whole api crate's 500 paths, not just the public endpoints.

Scope note from the admin-CRUD work (merged `main` @ `c4e0c4c`): the new admin handlers follow the same pattern as the public surface — `.map_err(|_| StatusCode::INTERNAL_SERVER_ERROR)` with the underlying error discarded and no tracing. This affects `crates/api/src/admin_objects.rs`, `admin_vocab.rs`, and `admin_authorities.rs`. When wiring tracing, cover the whole `api` crate's 500 paths, not just the public endpoints.

logaritmisk closed this issue

2026-06-04 15:40:16 +00:00

logaritmisk referenced this issue from a commit

2026-06-04 17:41:30 +00:00

fix(api): 404 when adding a term to a missing vocabulary (#22); log public 500s (#18)

logaritmisk referenced this issue from a commit

2026-06-04 17:41:31 +00:00

merge: tier 2 papercuts (#22 #18 #9 #4 #34 #31 #32 #37)

Sign in to join this conversation.