Return 404 (not 500) when adding a term to a non-existent vocabulary #22

New Issue

2026-06-02T21:02:02Z

logaritmisk commented

2026-06-02 21:02:02 +00:00

Context

POST /api/admin/vocabularies/{id}/terms (add_term in crates/api/src/admin_vocab.rs, merged at c4e0c4c) parses {id} as a VocabularyId and, if the UUID is well-formed but no such vocabulary exists, lets the insert hit a foreign-key violation. That FK error is mapped to 500 Internal Server Error.

A well-formed id pointing at a missing vocabulary is a client error, so the correct status is 404 Not Found (consistent with how the object/term/authority endpoints treat missing/unparseable ids elsewhere). Behaviour is safe today — the transaction rolls back — only the status code is coarse.

Task

In add_term, pre-check vocabulary existence (e.g. db::vocab::vocabulary_by_key/an existence query, or distinguish the FK violation from other sqlx::Errors) and return 404 when the vocabulary is absent.
Keep 500 only for genuine DB failures.

Acceptance

POST /api/admin/vocabularies/<valid-but-unknown-uuid>/terms → 404.
Adding a term to an existing vocabulary still → 201.
A test covers the missing-vocabulary case.

## Context `POST /api/admin/vocabularies/{id}/terms` (`add_term` in `crates/api/src/admin_vocab.rs`, merged at `c4e0c4c`) parses `{id}` as a `VocabularyId` and, if the UUID is well-formed but no such vocabulary exists, lets the insert hit a foreign-key violation. That FK error is mapped to **500 Internal Server Error**. A well-formed id pointing at a missing vocabulary is a **client** error, so the correct status is **404 Not Found** (consistent with how the object/term/authority endpoints treat missing/unparseable ids elsewhere). Behaviour is safe today — the transaction rolls back — only the status code is coarse. ## Task - In `add_term`, pre-check vocabulary existence (e.g. `db::vocab::vocabulary_by_key`/an existence query, or distinguish the FK violation from other `sqlx::Error`s) and return `404` when the vocabulary is absent. - Keep `500` only for genuine DB failures. ## Acceptance - `POST /api/admin/vocabularies/<valid-but-unknown-uuid>/terms` → `404`. - Adding a term to an existing vocabulary still → `201`. - A test covers the missing-vocabulary case.

logaritmisk closed this issue

2026-06-04 15:40:16 +00:00

logaritmisk referenced this issue from a commit

2026-06-04 17:41:30 +00:00

fix(api): 404 when adding a term to a missing vocabulary (#22); log public 500s (#18)

logaritmisk referenced this issue from a commit

2026-06-04 17:41:31 +00:00

merge: tier 2 papercuts (#22 #18 #9 #4 #34 #31 #32 #37)

Sign in to join this conversation.