Three review findings on task 4: - read_plist_fields now parses the plist properly via the plist crate (already a transitive dep of service-manager, promoted to direct) instead of slicing raw XML, so a PATH or program path containing & or < no longer round-trips as literal &/< through cli::service::render_status. - launchctl's error path now includes both stdout and stderr, trimmed and joined only on non-empty parts, so a failure never surfaces as "launchctl load failed: " with nothing after the colon. - status() now returns identical None fields (program, path_env, snapshotted, pid) whether the plist is absent or the plist exists but the crate reports NotInstalled (e.g. written but never loaded, or booted out of band) - extracted via a shared not_installed_status/build_status split so both paths run the same code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EGntTHCW3sEPy1VBRopNNp
38 lines
952 B
TOML
38 lines
952 B
TOML
[workspace]
|
|
resolver = "3"
|
|
members = [
|
|
"crates/xy-protocol",
|
|
"crates/xy-supervisor",
|
|
"crates/xy-ipc",
|
|
"crates/xy",
|
|
]
|
|
|
|
[workspace.package]
|
|
edition = "2024"
|
|
version = "0.1.0"
|
|
license = "MIT OR Apache-2.0"
|
|
|
|
[workspace.dependencies]
|
|
xy-protocol = { path = "crates/xy-protocol" }
|
|
xy-supervisor = { path = "crates/xy-supervisor" }
|
|
xy-ipc = { path = "crates/xy-ipc" }
|
|
|
|
tokio = { version = "1", features = ["rt-multi-thread", "net", "process", "signal", "sync", "fs", "io-util", "macros", "time"] }
|
|
serde = { version = "1", features = ["derive"] }
|
|
serde_json = "1"
|
|
thiserror = "2"
|
|
anyhow = "1"
|
|
tracing = "0.1"
|
|
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
|
|
clap = { version = "4", features = ["derive"] }
|
|
kdl = "6"
|
|
etcetera = "0.10"
|
|
nix = { version = "0.30", features = ["signal", "process"] }
|
|
humantime = "2"
|
|
humantime-serde = "1"
|
|
async-trait = "0.1"
|
|
tempfile = "3"
|
|
tokio-test = "0.4"
|
|
service-manager = "0.11"
|
|
plist = "1"
|