logaritmiskandClaude Opus 5
c12bc830a5
Three issues from two downstream consumers, all small, all sharing a theme: the crate had the information and would not hand it over. #44 — `UnknownKey { team: 0, member: 0 }` did not say which key. A consumer upgrading 0.1.2 -> 0.4.1 had every one of 5591 predictions return this error, fell back to a neutral 0.5, and lost its entire metadata model for a day. Nothing crashed and nothing logged; it was found by sweeping an unrelated parameter and noticing the output did not move. The 0.4.0 change that made unknown keys an error was right — the error was just too anonymous to act on. It now carries the key's `Debug` rendering, and its `Display` says what to do about it. The precondition is documented on every prediction entry point, which the reporter said would alone have saved the day. #43 — `cdf` was `pub(crate)`, so a consumer asking "is this competitor below the cutoff" approximated it with a `mu + z * sigma` band and had no way to say what confidence any `z` bought. Adds `Gaussian::probability_below` / `probability_above`. The second is separate on purpose: `1 - cdf` collapses to exactly zero past ~8.3 sigma, and a stopping rule is evaluated precisely there. Both route through the survival function added in 0.4.1, so this is visibility rather than new numerics. #50 — `ConvergenceReport` was not `#[must_use]`, so the one signal that a fit stopped short was trivially discarded. It now is, and that immediately found 78 sites doing exactly that — including this crate's own ATP example, which was capped at 10 sweeps when the history needs 30. The example now reads the report and says so. `ITERATIONS = 30` is documented as the floor it is, with the three measurements to hand: 400 events over 100 competitors already stops there at ~7e-3 against a 1e-6 tolerance, the ATP example needs 30 at a much looser one, and a consumer's 2000-node model needs 76 to 161. BREAKING CHANGE: `InferenceError::UnknownKey` gains a `key` field, and the prediction methods now require `K: Debug` in order to fill it. Closes #43, #50. Refs #44 — its third ask, an opt-in `UnknownKeys::Skip` mode, is a live API question and deliberately not answered here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011hcFjNDmHXZF8URGLku5zZ
56 lines
1.3 KiB
Rust
56 lines
1.3 KiB
Rust
use trueskill_tt::{ConstantDrift, ConvergenceOptions, History};
|
|
|
|
#[test]
|
|
fn record_winner_builds_history() {
|
|
let mut h = History::builder()
|
|
.mu(25.0)
|
|
.sigma(25.0 / 3.0)
|
|
.beta(25.0 / 6.0)
|
|
.drift(ConstantDrift(25.0 / 300.0))
|
|
.convergence(ConvergenceOptions {
|
|
max_iter: 30,
|
|
epsilon: 1e-6,
|
|
alpha: 1.0,
|
|
})
|
|
.build();
|
|
|
|
h.record_winner(&"alice", &"bob", 1).unwrap();
|
|
let _ = h.converge().unwrap();
|
|
|
|
let a_idx = h.lookup(&"alice").unwrap();
|
|
let b_idx = h.lookup(&"bob").unwrap();
|
|
|
|
assert_ne!(a_idx, b_idx);
|
|
}
|
|
|
|
#[test]
|
|
fn intern_is_idempotent() {
|
|
let mut h: History = History::builder().build();
|
|
let a1 = h.intern(&"alice");
|
|
let a2 = h.intern(&"alice");
|
|
assert_eq!(a1, a2);
|
|
}
|
|
|
|
#[test]
|
|
fn lookup_returns_none_for_missing() {
|
|
let h: History = History::builder().build();
|
|
assert!(h.lookup(&"nobody").is_none());
|
|
}
|
|
|
|
#[test]
|
|
fn record_draw_with_p_draw_set() {
|
|
let mut h = History::builder()
|
|
.mu(25.0)
|
|
.sigma(25.0 / 3.0)
|
|
.beta(25.0 / 6.0)
|
|
.drift(ConstantDrift(25.0 / 300.0))
|
|
.p_draw(0.25)
|
|
.build();
|
|
|
|
h.record_draw(&"alice", &"bob", 1).unwrap();
|
|
let _ = h.converge().unwrap();
|
|
|
|
assert!(h.lookup(&"alice").is_some());
|
|
assert!(h.lookup(&"bob").is_some());
|
|
}
|