logaritmisk

logaritmisk closed issue logaritmisk/trueskill-tt#77

2026-09-09 19:53:56 +00:00

Docs: no README quickstart, 112 missing_docs warnings, and the only Joint example does not compile downstream

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 19:53:56 +00:00

251211f134 Merge docs/missing-docs (#77, #75)

31564b71a0 docs: document the whole public surface and deny(missing_docs)

Compare 2 commits »

logaritmisk commented on issue logaritmisk/trueskill-tt#78

2026-09-09 19:41:05 +00:00

predict_* returns Ok on a NaN-poisoned fit, and eight # Errors sections do not match the code

Parts 1 and 2 are done in 9d3e002 (merged as 78810c0). Parts 3 and 4 are design calls and stay open — see the bottom.

Part 1 — reproduced, then fixed

The three rows reproduce exactly as…

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 19:40:44 +00:00

78810c0344 Merge fix/predict-non-finite-guard (#78 parts 1-2)

9d3e002be3 fix!: no prediction path answers from a fit it cannot answer from

Compare 2 commits »

logaritmisk commented on issue logaritmisk/trueskill-tt#76

2026-09-09 19:29:30 +00:00

History has no Debug, and trait impls are inconsistent across the public value types

Closed by 7ca0daa (merged as 9d629d0), together with earlier api/cleanup work.

Already landed before this commit: hand-written summarising Debug for History (competitor count, event count,…

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 19:29:20 +00:00

9d629d0d94 Merge api/trait-consistency (#76)

7ca0daa48e feat: PartialEq on the config types, and pin the public trait impls

Compare 2 commits »

logaritmisk closed issue logaritmisk/trueskill-tt#76

2026-09-09 19:29:20 +00:00

History has no Debug, and trait impls are inconsistent across the public value types

logaritmisk commented on issue logaritmisk/trueskill-tt#73

2026-09-09 19:25:03 +00:00

Six exported types are unreachable from History — removing them shrinks the API for free

Most of this is now done; one item is left and it is a design call, not a cleanup.

Already gone (the api/cleanup work, which moved benches/batch.rs onto the public API and so freed the…

logaritmisk commented on issue logaritmisk/trueskill-tt#67

2026-09-09 19:24:49 +00:00

A dropped EventBuilder silently ingests nothing — no #[must_use]

Fixed in e4d6dc4 (merged as c3d1afe).

The rule the issue asked for: #[must_use] goes on the type, not on each method. That covers every constructor and builder setter in one place, so there…

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 19:24:41 +00:00

c3d1afe448 Merge api/must-use-and-visibility (#67, #73)

e4d6dc4028 fix: warn on dropped builders and values; stop exporting EP internals

Compare 2 commits »

logaritmisk closed issue logaritmisk/trueskill-tt#67

2026-09-09 19:24:41 +00:00

A dropped EventBuilder silently ingests nothing — no #[must_use]

logaritmisk commented on issue logaritmisk/trueskill-tt#70

2026-09-09 19:19:30 +00:00

Accessors disagree on how they report an unknown key, and learning_curve cannot distinguish a typo from a registered competitor

The additive half of this issue is now done too, in 86e1521 (merged as cc601c0).

competitors(), competitor_count(), event_count() — landed earlier in the api/cleanup work.
`current_sk…

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 19:19:25 +00:00

cc601c06eb Merge feat/evidence-matrix: the missing evidence corner (#70)

86e1521f8a feat: complete the evidence matrix and add current_skills

Compare 2 commits »

logaritmisk commented on issue logaritmisk/trueskill-tt#70

2026-09-09 19:14:03 +00:00

Accessors disagree on how they report an unknown key, and learning_curve cannot distinguish a typo from a registered competitor

Done in e4a68ba (merged as 60fc3e9), for the two curve accessors.

learning_curve and filtered_learning_curve now return Option<Vec<(T, Gaussian)>>: None for a key the history has never…

logaritmisk commented on issue logaritmisk/trueskill-tt#66

2026-09-09 19:13:53 +00:00

log_evidence_for silently returns whole-history evidence for an unknown key

Fixed in e4a68ba (merged as 60fc3e9).

log_evidence_for now returns Result<f64, InferenceError> and reports UnknownKey { member, .. } naming the offending position, rather than silently…

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 19:13:42 +00:00

60fc3e9d05 Merge fix/honest-accessors: honest per-key queries (#66, #70)

e4a68ba1a7 fix!: per-key queries report unknown keys instead of a plausible constant

Compare 2 commits »

logaritmisk closed issue logaritmisk/trueskill-tt#66

2026-09-09 19:13:42 +00:00

log_evidence_for silently returns whole-history evidence for an unknown key

logaritmisk closed issue logaritmisk/trueskill-tt#70

2026-09-09 19:13:42 +00:00

Accessors disagree on how they report an unknown key, and learning_curve cannot distinguish a typo from a registered competitor

logaritmisk pushed to main at logaritmisk/trueskill-tt

2026-09-09 18:57:42 +00:00

56e8220c86 Merge branch 'api/cleanup'

fdd1539cab refactor: one word per concept

85c4d0d87d fix!: correct eight wrong # Errors sections and seal the error variants

a0c2f78aed feat: add the missing trait impls and make #[must_use] consistent

4472d98b56 refactor!: un-export six types that no caller could reach

Compare 5 commits »

logaritmisk closed issue logaritmisk/trueskill-tt#68

2026-09-09 18:21:58 +00:00

The Time generic is unreachable downstream — Untimed and custom timestamps cannot be used at all