logaritmisk/xy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(spec): drop the unnecessary MakeWriter newtype

Browse Source 
tracing-subscriber already impls MakeWriter for Mutex<W: io::Write> and
Arc<W>, so Arc<Mutex<RotatingLogWriter>> satisfies with_writer directly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EGntTHCW3sEPy1VBRopNNp
This commit is contained in:
logaritmisk
2026-07-31 22:24:51 +02:00
co-authored by Claude Opus 5
parent dff798a9be
commit f74eb1e865
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/superpowers/specs/2026-07-31-xy-start-on-login-design.md
+5 -2
View File
@@ -154,8 +154,11 @@ which is too late to open a log file for the logger itself.
For the `Cmd::Daemon` arm only, the subscriber writes to `stderr.and(file)` via For the `Cmd::Daemon` arm only, the subscriber writes to `stderr.and(file)` via
`MakeWriterExt`, where the file half is `log_dir/xy.log` backed by the existing `MakeWriterExt`, where the file half is `log_dir/xy.log` backed by the existing
`xy_supervisor::logs::RotatingLogWriter` (10 MB × 5, the same rotation used for `xy_supervisor::logs::RotatingLogWriter` (10 MB × 5, the same rotation used for
per-server logs). A small `MakeWriter` newtype wrapping per-server logs). No adapter type is needed: `tracing-subscriber` 0.3 already
`Arc<Mutex<RotatingLogWriter>>` bridges the two. implements `MakeWriter` for `Mutex<W> where W: io::Write` (`fmt/writer.rs:808`)
and for `Arc<W> where W: MakeWriter` (`fmt/writer.rs:694`), so
`Arc<Mutex<RotatingLogWriter>>` satisfies the bound once Task 1 lands the
`io::Write` impl.
Every other subcommand keeps stderr-only logging; CLI output does not belong in Every other subcommand keeps stderr-only logging; CLI output does not belong in
the daemon's log. the daemon's log.