From 52f5f76a34bbdc636d7a5a4403812062b26910de Mon Sep 17 00:00:00 2001 From: Anders Olsson Date: Fri, 24 Apr 2026 10:38:22 +0200 Subject: [PATCH] refactor(lib): make key_table module private; revert bench var rename MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address code review feedback from Task 2: - key_table module doesn't need pub visibility; the KeyTable re-export at lib.rs root already exposes the only public type. Matches the error/history private-module pattern. - Revert an incidental bench variable rename (index_map → index) that wasn't part of the task scope. Co-Authored-By: Claude Opus 4.7 (1M context) --- benches/batch.rs | 8 ++++---- src/lib.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/benches/batch.rs b/benches/batch.rs index 505e2f9..fbdacb3 100644 --- a/benches/batch.rs +++ b/benches/batch.rs @@ -5,11 +5,11 @@ use trueskill_tt::{ }; fn criterion_benchmark(criterion: &mut Criterion) { - let mut index = KeyTable::new(); + let mut index_map = KeyTable::new(); - let a = index.get_or_create("a"); - let b = index.get_or_create("b"); - let c = index.get_or_create("c"); + let a = index_map.get_or_create("a"); + let b = index_map.get_or_create("b"); + let c = index_map.get_or_create("c"); let mut agents: AgentStore = AgentStore::new(); diff --git a/src/lib.rs b/src/lib.rs index 0afdc64..0eb8d02 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,7 +14,7 @@ pub(crate) mod factor; mod game; pub mod gaussian; mod history; -pub mod key_table; +mod key_table; mod matrix; pub mod player; pub(crate) mod schedule;