Fix clippy warning

src/batch.rs

@@ -14,7 +14,7 @@ pub(crate) struct Skill {
 }
 
 impl Skill {
-    fn posterior(&self) -> Gaussian {
+    pub(crate) fn posterior(&self) -> Gaussian {
         self.likelihood * self.backward * self.forward
     }
 }
@@ -251,6 +251,7 @@ impl Batch {
         self.iteration(from, agents);
     }
 
+    // TODO(anders): Use Item::posterior() instead.
     pub fn posterior(&self, agent: Index) -> Gaussian {
         let skill = &self.skills[&agent];
 
@@ -259,8 +260,8 @@ impl Batch {
 
     pub(crate) fn posteriors(&self) -> HashMap<Index, Gaussian> {
         self.skills
-            .keys()
+            .iter()
-            .map(|&idx| (idx, self.posterior(idx)))
+            .map(|(&idx, skill)| (idx, skill.posterior()))
             .collect::<HashMap<_, _>>()
     }
 
@@ -388,8 +389,7 @@ impl Batch {
             } else {
                 self.events.iter().map(|event| event.evidence.ln()).sum()
             }
-        } else {
+        } else if online || forward {
-            if online || forward {
             self.events
                 .iter()
                 .enumerate()
@@ -425,7 +425,6 @@ impl Batch {
                 .sum()
         }
     }
-    }
 
     pub fn get_composition(&self) -> Vec<Vec<Vec<Index>>> {
         self.events

src/history.rs

@@ -210,8 +210,8 @@ impl History {
         let mut data: HashMap<Index, Vec<(i64, Gaussian)>> = HashMap::new();
 
         for b in &self.batches {
-            for agent in b.skills.keys() {
+            for (agent, skill) in b.skills.iter() {
-                let point = (b.time, b.posterior(*agent));
+                let point = (b.time, skill.posterior());
 
                 if let Some(entry) = data.get_mut(agent) {
                     entry.push(point);