logaritmisk/pure
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable interactive passwords in SSH for git fetch (#269)

Browse Source 
This commit fixes a problem where SSH (used by Git) is able to
interactively prompt for a password that can not be redirected to
`/dev/null`.

An interactive SSH password prompt inside the async worker does three
things:
1. Leave the `git fetch` hanging due to waiting for input
2. Capture part of the input to the async worker, thus creating
   nonsense commands
3. Use some characters from future async jobs as a password and
   attempts to login

Even if this was fixed in `zsh-async`, it is still good to disable the
password prompt to avoid issue numero uno.
This commit is contained in:
Mathias Fredriksson
2017-01-16 05:10:36 +02:00
committed by Sindre Sorhus
parent caafdf582a
commit ee0c6a445a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pure.zsh
View File

@@ -256,7 +256,11 @@ prompt_pure_async_git_fetch() {
builtin cd -q "$*" builtin cd -q "$*"
# set GIT_TERMINAL_PROMPT=0 to disable auth prompting for git fetch (git 2.3+) # set GIT_TERMINAL_PROMPT=0 to disable auth prompting for git fetch (git 2.3+)
GIT_TERMINAL_PROMPT=0 command git -c gc.auto=0 fetch export GIT_TERMINAL_PROMPT=0
# set ssh BachMode to disable all interactive ssh password prompting
export GIT_SSH_COMMAND=${GIT_SSH_COMMAND:-"ssh -o BatchMode=yes"}
command git -c gc.auto=0 fetch
} }
prompt_pure_async_tasks() { prompt_pure_async_tasks() {