Refactor, and passing tests

This commit is contained in:
2021-05-26 18:39:46 +02:00
parent 2dca63b1c9
commit 32dafd4e54
7 changed files with 121 additions and 76 deletions

View File

@@ -112,8 +112,8 @@ impl BinaryModel {
for obs in &mut self.observations {
let diff = match method {
BinaryModelFitMethod::Ep => obs.ep_update(lr, &mut self.storage),
BinaryModelFitMethod::Kl => obs.kl_update(lr, &mut self.storage),
BinaryModelFitMethod::Ep => obs.ep_update(&mut self.storage, lr),
BinaryModelFitMethod::Kl => obs.kl_update(&mut self.storage, lr),
};
if diff > max_diff {

View File

@@ -130,8 +130,8 @@ impl TernaryModel {
for obs in &mut self.observations {
let diff = match method {
TernaryModelFitMethod::Ep => obs.ep_update(lr, &mut self.storage),
TernaryModelFitMethod::Kl => obs.kl_update(lr, &mut self.storage),
TernaryModelFitMethod::Ep => obs.ep_update(&mut self.storage, lr),
TernaryModelFitMethod::Kl => obs.kl_update(&mut self.storage, lr),
};
if diff > max_diff {