Keep authority.kind CHECK in sync with the AuthorityKind enum #9

New Issue

2026-06-02T07:07:49Z

logaritmisk commented

2026-06-02 07:07:49 +00:00

The allowed authority kinds live in two places with no compile-time link:

SQL: CHECK (kind IN ('person', 'organisation', 'place')) in crates/db/migrations/0002_vocabularies_authorities.sql
Rust: AuthorityKind (as_str/from_db) in crates/domain/src/authority.rs

They agree today, but adding a variant requires editing both by hand. Same pattern applies to AuditAction vs the action CHECK in 0001. Low priority; options: a cross-referencing comment in each location, or generate the CHECK list from the enum. Revisit if the variant sets grow.

Source: Plan 2 (vocab/authorities) final review — non-blocking.

The allowed authority kinds live in two places with no compile-time link: - SQL: `CHECK (kind IN ('person', 'organisation', 'place'))` in `crates/db/migrations/0002_vocabularies_authorities.sql` - Rust: `AuthorityKind` (`as_str`/`from_db`) in `crates/domain/src/authority.rs` They agree today, but adding a variant requires editing both by hand. Same pattern applies to `AuditAction` vs the `action` CHECK in 0001. Low priority; options: a cross-referencing comment in each location, or generate the CHECK list from the enum. Revisit if the variant sets grow. _Source: Plan 2 (vocab/authorities) final review — non-blocking._

logaritmisk closed this issue

2026-06-04 15:40:21 +00:00

logaritmisk referenced this issue from a commit

2026-06-04 17:41:30 +00:00

chore: cross-ref enum/CHECK constraints (#9); drop dead clone + harden smoke test (#4)

logaritmisk referenced this issue from a commit

2026-06-04 17:41:31 +00:00

merge: tier 2 papercuts (#22 #18 #9 #4 #34 #31 #32 #37)

Sign in to join this conversation.