logaritmisk/biggus-dickus
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

Extend the audit log to cover auth/security events #7

New Issue
Open
opened 2026-06-02 06:09:59 +00:00 by logaritmisk · 1 comment
logaritmisk commented 2026-06-02 06:09:59 +00:00
Owner
Copy Link
Copy Source

Spec §13 says the audit log should also cover auth/security events (login success/failure, permission changes), but the current spine is entity-centric: AuditAction is only created/updated/deleted and entity_type/entity_id are NOT NULL (crates/domain/src/audit.rs, crates/db/migrations/0001_audit_log.sql).

When auth lands (Plan 9), extend the model to represent auth events cleanly — e.g. an expanded action set plus a nullable or "auth"-typed entity reference, or a sibling table. Decide the shape then.

Also at that time: replace the placeholder AuditActor::User(Uuid) with the new UserId newtype (db maps to/from a raw UUID column, so it's a type-side change).

Source: Plan 1 (audit spine) final review — forward-looking, belongs with Plan 9 (auth).

Spec §13 says the audit log should also cover **auth/security events** (login success/failure, permission changes), but the current spine is entity-centric: `AuditAction` is only `created`/`updated`/`deleted` and `entity_type`/`entity_id` are `NOT NULL` (`crates/domain/src/audit.rs`, `crates/db/migrations/0001_audit_log.sql`). When auth lands (Plan 9), extend the model to represent auth events cleanly — e.g. an expanded action set plus a nullable or `"auth"`-typed entity reference, or a sibling table. Decide the shape then. Also at that time: replace the placeholder `AuditActor::User(Uuid)` with the new `UserId` newtype (db maps to/from a raw `UUID` column, so it's a type-side change). _Source: Plan 1 (audit spine) final review — forward-looking, belongs with Plan 9 (auth)._
logaritmisk commented 2026-06-02 21:02:16 +00:00
Author
Owner
Copy Link
Copy Source

Progress/scope note from the admin-CRUD work (merged main @ c4e0c4c): admin catalogue object writes (create/update/delete/set_fields, in crates/api/src/admin_objects.rs) now correctly record AuditActor::User(<real uuid>) extracted from the authenticated session.

Still pending under this issue: set_visibility (the publish endpoint) continues to record AuditActor::System — it carries a TODO(#7) in code. Capturing the real acting user there (and login/logout/auth-event auditing) remains the scope of this issue.

Progress/scope note from the admin-CRUD work (merged `main` @ `c4e0c4c`): admin catalogue **object** writes (create/update/delete/set_fields, in `crates/api/src/admin_objects.rs`) now correctly record `AuditActor::User(<real uuid>)` extracted from the authenticated session. Still pending under this issue: `set_visibility` (the publish endpoint) continues to record `AuditActor::System` — it carries a `TODO(#7)` in code. Capturing the real acting user there (and login/logout/auth-event auditing) remains the scope of this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
logaritmisk
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: logaritmisk/biggus-dickus#7
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?