Frontend M4 polish: ARIA tab semantics for authority kind tabs + remove unused i18n keys #32

New Issue

2026-06-04T07:43:34Z

logaritmisk commented

2026-06-04 07:43:34 +00:00

Minor cleanups from the Milestone 4 final review (non-blocking, bundled):

ARIA tab semantics — the authority kind selector (web/src/authorities/authorities-page.tsx) renders the person/organisation/place tabs as plain NavLinks styled as tabs, with no role="tablist" / role="tab" / aria-selected. They work, but screen-reader users don't get tab semantics. Either adopt proper tab roles or a shadcn Tabs primitive driven by the route.
Unused i18n keys — vocab.title and authorities.title are defined in both en.json and sv.json but never referenced (the nav uses the nav.* keys instead). Either use them as visible page/section headings on the respective screens, or remove them. (en/sv parity must be preserved either way.)

Both are cosmetic/a11y polish; no functional impact.

Minor cleanups from the Milestone 4 final review (non-blocking, bundled): 1. **ARIA tab semantics** — the authority kind selector (`web/src/authorities/authorities-page.tsx`) renders the person/organisation/place tabs as plain `NavLink`s styled as tabs, with no `role="tablist"` / `role="tab"` / `aria-selected`. They work, but screen-reader users don't get tab semantics. Either adopt proper tab roles or a shadcn Tabs primitive driven by the route. 2. **Unused i18n keys** — `vocab.title` and `authorities.title` are defined in both `en.json` and `sv.json` but never referenced (the nav uses the `nav.*` keys instead). Either use them as visible page/section headings on the respective screens, or remove them. (en/sv parity must be preserved either way.) Both are cosmetic/a11y polish; no functional impact.

logaritmisk closed this issue

2026-06-04 15:40:22 +00:00

logaritmisk referenced this issue from a commit

2026-06-04 17:41:31 +00:00

fix(web): search 503 vs error (#34); terms/authorities list error states (#31); authority-tab a11y + dead keys (#32); authority-kind test (#37)

logaritmisk referenced this issue from a commit

2026-06-04 17:41:31 +00:00

fix(web): place aria-selected on the role=tab element (#32) + assert it

logaritmisk referenced this issue from a commit

2026-06-04 17:41:31 +00:00

merge: tier 2 papercuts (#22 #18 #9 #4 #34 #31 #32 #37)

Sign in to join this conversation.