Audit vocabulary/term/authority creation (admin writes currently unaudited) #21

New Issue

2026-06-02T21:01:55Z

logaritmisk commented

2026-06-02 21:01:55 +00:00

Context

The admin CRUD surface (merged to main at c4e0c4c) added write endpoints for controlled vocabularies, terms, and authority records:

POST /api/admin/vocabularies → db::vocab::create_vocabulary
POST /api/admin/vocabularies/{id}/terms → db::vocab::add_term
POST /api/admin/authorities → db::authority::create_authority

Unlike catalogue object writes (which now record AuditActor::User(<real uuid>)), these three creation paths are not audited — the underlying db functions take no AuditActor argument, so there is no audit path to thread a user through.

This was a deliberate, documented MVP deferral (see docs/plans/2026-06-02-admin-crud.md → "Notes for follow-on plans"), not an oversight.

Task

Add an AuditActor parameter to db::vocab::create_vocabulary / add_term and db::authority::create_authority.
Record an audit entry on each (consistent with how object/user writes are audited).
Thread the authenticated user (actor(&auth.user)) through the three admin handlers in crates/api/src/admin_vocab.rs and crates/api/src/admin_authorities.rs.

Acceptance

Creating a vocabulary, term, or authority via the admin API writes an audit entry attributing the real acting user.
Existing tests stay green; add coverage asserting the audit row is written.

## Context The admin CRUD surface (merged to `main` at `c4e0c4c`) added write endpoints for controlled vocabularies, terms, and authority records: - `POST /api/admin/vocabularies` → `db::vocab::create_vocabulary` - `POST /api/admin/vocabularies/{id}/terms` → `db::vocab::add_term` - `POST /api/admin/authorities` → `db::authority::create_authority` Unlike catalogue **object** writes (which now record `AuditActor::User(<real uuid>)`), these three creation paths are **not audited** — the underlying `db` functions take no `AuditActor` argument, so there is no audit path to thread a user through. This was a deliberate, documented MVP deferral (see `docs/plans/2026-06-02-admin-crud.md` → "Notes for follow-on plans"), not an oversight. ## Task - Add an `AuditActor` parameter to `db::vocab::create_vocabulary` / `add_term` and `db::authority::create_authority`. - Record an audit entry on each (consistent with how object/user writes are audited). - Thread the authenticated user (`actor(&auth.user)`) through the three admin handlers in `crates/api/src/admin_vocab.rs` and `crates/api/src/admin_authorities.rs`. ## Acceptance - Creating a vocabulary, term, or authority via the admin API writes an audit entry attributing the real acting user. - Existing tests stay green; add coverage asserting the audit row is written.

logaritmisk referenced this issue

2026-06-04 07:43:21 +00:00

Backend: edit/delete endpoints for vocabularies, terms, and authorities #30

logaritmisk referenced this issue

2026-06-04 12:36:46 +00:00

Backend + frontend: edit/delete field definitions #36

logaritmisk closed this issue

2026-06-04 20:10:21 +00:00

logaritmisk referenced this issue from a commit

2026-06-05 13:21:46 +00:00

docs(plans): tier 4 hardening batch 1 (#1 #2 #21)

logaritmisk referenced this issue from a commit