feat(web): object-detail tab title, caption element fix, login title (#57)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-07 17:22:18 +02:00
parent 6e1f5ea50f
commit 8511aebb53
4 changed files with 28 additions and 6 deletions
+5 -1
View File
@@ -1,4 +1,4 @@
import { useState, type FormEvent } from "react"; import { useEffect, useState, type FormEvent } from "react";
import { useNavigate } from "react-router-dom"; import { useNavigate } from "react-router-dom";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
@@ -14,6 +14,10 @@ export function LoginPage() {
const [email, setEmail] = useState(""); const [email, setEmail] = useState("");
const [password, setPassword] = useState(""); const [password, setPassword] = useState("");
useEffect(() => {
document.title = t("app.name");
}, [t]);
const onSubmit = (event: FormEvent) => { const onSubmit = (event: FormEvent) => {
event.preventDefault(); event.preventDefault();
login.mutate( login.mutate(
+9 -1
View File
@@ -1,5 +1,5 @@
import { expect, test } from "vitest"; import { expect, test } from "vitest";
import { screen, within } from "@testing-library/react"; import { screen, waitFor, within } from "@testing-library/react";
import { http, HttpResponse } from "msw"; import { http, HttpResponse } from "msw";
import { Routes, Route } from "react-router-dom"; import { Routes, Route } from "react-router-dom";
import { server } from "../test/server"; import { server } from "../test/server";
@@ -96,6 +96,14 @@ test("shows a not-found state for a missing object", async () => {
expect(await screen.findByText(/object not found/i)).toBeInTheDocument(); expect(await screen.findByText(/object not found/i)).toBeInTheDocument();
}); });
test("sets the tab title to the object number and reverts on unmount", async () => {
document.title = "Base";
const { unmount } = renderDetail();
await waitFor(() => expect(document.title).toMatch(/^LM-0042 \| /));
unmount();
expect(document.title).toBe("Base");
});
test("detail shows the publish control with the current visibility stepper", async () => { test("detail shows the publish control with the current visibility stepper", async () => {
// default GET /api/admin/objects/:id handler returns amphora (visibility "public") // default GET /api/admin/objects/:id handler returns amphora (visibility "public")
renderApp(tree(), { route: "/objects/11111111-1111-1111-1111-111111111111" }); renderApp(tree(), { route: "/objects/11111111-1111-1111-1111-111111111111" });
+12 -2
View File
@@ -5,6 +5,7 @@ import { useTranslation } from "react-i18next";
import type { components } from "../api/schema"; import type { components } from "../api/schema";
import { useObject, useFieldDefinitions } from "../api/queries"; import { useObject, useFieldDefinitions } from "../api/queries";
import { formatDate } from "../lib/format-date"; import { formatDate } from "../lib/format-date";
import { useDocumentTitle } from "../lib/use-document-title";
import { DeleteObjectDialog } from "./delete-object-dialog"; import { DeleteObjectDialog } from "./delete-object-dialog";
import { FlexibleFieldValue } from "./flexible-field-value"; import { FlexibleFieldValue } from "./flexible-field-value";
import { PublishControl } from "./publish-control"; import { PublishControl } from "./publish-control";
@@ -13,6 +14,7 @@ import { buttonVariants } from "@/components/ui/button";
import { Skeleton } from "@/components/ui/skeleton"; import { Skeleton } from "@/components/ui/skeleton";
type FieldDefinitionView = components["schemas"]["FieldDefinitionView"]; type FieldDefinitionView = components["schemas"]["FieldDefinitionView"];
type AdminObjectView = components["schemas"]["AdminObjectView"];
function Field({ label, value }: { label: string; value: ReactNode }) { function Field({ label, value }: { label: string; value: ReactNode }) {
const empty = value === null || value === undefined || value === ""; const empty = value === null || value === undefined || value === "";
@@ -26,10 +28,9 @@ function Field({ label, value }: { label: string; value: ReactNode }) {
} }
export function ObjectDetail() { export function ObjectDetail() {
const { t, i18n } = useTranslation(); const { t } = useTranslation();
const { id } = useParams(); const { id } = useParams();
const { data: object, isLoading, isError } = useObject(id!); const { data: object, isLoading, isError } = useObject(id!);
const { data: definitions } = useFieldDefinitions();
if (isLoading) { if (isLoading) {
return ( return (
@@ -43,6 +44,15 @@ export function ObjectDetail() {
if (!object) return <p className="p-4 text-sm text-muted-foreground">{t("objects.notFound")}</p>; if (!object) return <p className="p-4 text-sm text-muted-foreground">{t("objects.notFound")}</p>;
return <ObjectDetailLoaded object={object} />;
}
function ObjectDetailLoaded({ object }: { object: AdminObjectView }) {
const { t, i18n } = useTranslation();
const { data: definitions } = useFieldDefinitions();
useDocumentTitle(object.object_number);
// Prefer the active locale's label, then English, then the raw key. // Prefer the active locale's label, then English, then the raw key.
const lang = i18n.language.startsWith("sv") ? "sv" : "en"; const lang = i18n.language.startsWith("sv") ? "sv" : "en";
const labelFor = (key: string) => { const labelFor = (key: string) => {
+2 -2
View File
@@ -49,9 +49,9 @@ export function VocabularyTerms() {
return ( return (
<div className="overflow-auto p-4"> <div className="overflow-auto p-4">
<h3 className="mb-2 label-caption"> <div className="mb-2 label-caption">
{t("vocab.terms")} {t("vocab.terms")}
</h3> </div>
<ul className="mb-4"> <ul className="mb-4">
{isLoading && ( {isLoading && (
<li className="text-sm text-muted-foreground"></li> <li className="text-sm text-muted-foreground"></li>