feat(web): edit/delete field definitions on /fields (in-place edit pane) (#36)

web/src/fields/field-form.tsx

@@ -2,7 +2,11 @@ import { useState, type FormEvent } from "react";
 import { useTranslation } from "react-i18next";
 
 import type { components } from "../api/schema";
-import { useCreateFieldDefinition, useVocabularies } from "../api/queries";
+import {
+  useCreateFieldDefinition,
+  useUpdateFieldDefinition,
+  useVocabularies,
+} from "../api/queries";
 import { LabelEditor } from "../components/label-editor";
 import { Button } from "@/components/ui/button";
 import { Input } from "@/components/ui/input";
@@ -10,68 +14,103 @@ import { Label } from "@/components/ui/label";
 import { Checkbox } from "@/components/ui/checkbox";
 
 type LabelInput = components["schemas"]["LabelInput"];
+type FieldDefinitionView = components["schemas"]["FieldDefinitionView"];
 
 const TYPES = ["text", "localized_text", "integer", "date", "boolean", "term", "authority"] as const;
 const KINDS = ["person", "organisation", "place"] as const;
 
-export function FieldForm() {
+export function FieldForm({
+  editing,
+  onDone,
+}: {
+  editing: FieldDefinitionView | null;
+  onDone: () => void;
+}) {
   const { t } = useTranslation();
   const create = useCreateFieldDefinition();
+  const update = useUpdateFieldDefinition();
   const { data: vocabularies } = useVocabularies();
 
-  const [key, setKey] = useState("");
-  const [labels, setLabels] = useState<LabelInput[]>([]);
-  const [dataType, setDataType] = useState<string>("text");
-  const [vocabularyId, setVocabularyId] = useState("");
-  const [authorityKind, setAuthorityKind] = useState("");
-  const [group, setGroup] = useState("");
-  const [required, setRequired] = useState(false);
-  const [error, setError] = useState(false);
+  const isEdit = editing !== null;
 
-  const reset = () => {
-    setKey("");
-    setLabels([]);
-    setDataType("text");
-    setVocabularyId("");
-    setAuthorityKind("");
-    setGroup("");
-    setRequired(false);
-    setError(false);
-  };
+  const [key, setKey] = useState(editing?.key ?? "");
+  const [labels, setLabels] = useState<LabelInput[]>((editing?.labels as LabelInput[]) ?? []);
+  const [dataType, setDataType] = useState<string>(editing?.data_type ?? "text");
+  const [vocabularyId, setVocabularyId] = useState(editing?.vocabulary_id ?? "");
+  const [authorityKind, setAuthorityKind] = useState(editing?.authority_kind ?? "");
+  const [group, setGroup] = useState(editing?.group ?? "");
+  const [required, setRequired] = useState(editing?.required ?? false);
+  const [error, setError] = useState(false);
 
   const onSubmit = (event: FormEvent) => {
     event.preventDefault();
 
     const hasLabel = labels.some((l) => l.label);
-    const termNeedsVocab = dataType === "term" && !vocabularyId;
 
-    if (!key.trim() || !hasLabel || termNeedsVocab) {
+    if (!hasLabel || (!isEdit && !key.trim()) || (!isEdit && dataType === "term" && !vocabularyId)) {
       setError(true);
       return;
     }
 
     setError(false);
-    create.mutate(
-      {
-        key: key.trim(),
-        data_type: dataType,
-        vocabulary_id: dataType === "term" ? vocabularyId : null,
-        authority_kind: dataType === "authority" ? authorityKind || null : null,
-        required,
-        group: group.trim() || null,
-        labels,
-      },
-      { onSuccess: reset },
-    );
+
+    if (isEdit) {
+      update.mutate(
+        { key: editing.key, required, group: group.trim() || null, labels },
+        { onSuccess: onDone },
+      );
+    } else {
+      create.mutate(
+        {
+          key: key.trim(),
+          data_type: dataType,
+          vocabulary_id: dataType === "term" ? vocabularyId : null,
+          authority_kind: dataType === "authority" ? authorityKind || null : null,
+          required,
+          group: group.trim() || null,
+          labels,
+        },
+        {
+          onSuccess: () => {
+            setKey("");
+            setLabels([]);
+            setDataType("text");
+            setVocabularyId("");
+            setAuthorityKind("");
+            setGroup("");
+            setRequired(false);
+            setError(false);
+            onDone();
+          },
+        },
+      );
+    }
   };
 
+  const pending = isEdit ? update.isPending : create.isPending;
+  const failed = isEdit ? update.isError : create.isError;
+
   return (
     <form onSubmit={onSubmit} className="space-y-3 overflow-auto p-4">
-      <div className="text-sm font-medium">{t("fields.newField")}</div>
+      <div className="flex items-center justify-between">
+        <div className="text-sm font-medium">
+          {isEdit ? labelTextOrKey(editing) : t("fields.newField")}
+        </div>
+        {isEdit && (
+          <Button type="button" variant="ghost" size="sm" onClick={onDone}>
+            {t("form.cancel")}
+          </Button>
+        )}
+      </div>
 
       <div className="space-y-1">
         <Label htmlFor="field-key">{t("fields.key")}</Label>
-        <Input id="field-key" value={key} onChange={(e) => setKey(e.target.value)} />
+        <Input
+          id="field-key"
+          value={key}
+          disabled={isEdit}
+          onChange={(e) => setKey(e.target.value)}
+        />
       </div>
 
       <LabelEditor value={labels} onChange={setLabels} />
@@ -81,8 +120,9 @@ export function FieldForm() {
         <select
           id="field-type"
           value={dataType}
+          disabled={isEdit}
           onChange={(e) => setDataType(e.target.value)}
-          className="w-full rounded border px-2 py-1 text-sm"
+          className="w-full rounded border px-2 py-1 text-sm disabled:opacity-60"
         >
           {TYPES.map((type) => (
             <option key={type} value={type}>
@@ -98,8 +138,9 @@ export function FieldForm() {
           <select
             id="field-vocab"
             value={vocabularyId}
+            disabled={isEdit}
             onChange={(e) => setVocabularyId(e.target.value)}
-            className="w-full rounded border px-2 py-1 text-sm"
+            className="w-full rounded border px-2 py-1 text-sm disabled:opacity-60"
           >
             <option value="">{t("form.selectPlaceholder")}</option>
             {vocabularies?.map((vocab) => (
@@ -117,8 +158,9 @@ export function FieldForm() {
           <select
             id="field-kind"
             value={authorityKind}
+            disabled={isEdit}
             onChange={(e) => setAuthorityKind(e.target.value)}
-            className="w-full rounded border px-2 py-1 text-sm"
+            className="w-full rounded border px-2 py-1 text-sm disabled:opacity-60"
           >
             <option value="">{t("fields.anyKind")}</option>
             {KINDS.map((kind) => (
@@ -145,15 +187,19 @@ export function FieldForm() {
           {t("form.required")}
         </p>
       )}
-      {create.isError && (
+      {failed && (
         <p role="alert" className="text-xs text-red-600">
           {t("form.rejected")}
         </p>
       )}
 
-      <Button type="submit" size="sm" disabled={create.isPending}>
-        {t("fields.create")}
+      <Button type="submit" size="sm" disabled={pending}>
+        {isEdit ? t("actions.save") : t("fields.create")}
       </Button>
     </form>
   );
 }
+
+function labelTextOrKey(def: FieldDefinitionView): string {
+  return def.labels[0]?.label ?? def.key;
+}