feat(web): authorities kind-tabbed screen (list/create) + nav

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-06-04 09:32:57 +02:00
parent 02e4f34a1b
commit 38673e52ba
6 changed files with 159 additions and 1 deletions
+3
View File
@@ -10,6 +10,7 @@ import { SelectPrompt } from "./objects/select-prompt";
import { VocabulariesPage } from "./vocab/vocabularies-page"; import { VocabulariesPage } from "./vocab/vocabularies-page";
import { VocabularyTerms } from "./vocab/vocabulary-terms"; import { VocabularyTerms } from "./vocab/vocabulary-terms";
import { SelectVocabularyPrompt } from "./vocab/select-vocabulary-prompt"; import { SelectVocabularyPrompt } from "./vocab/select-vocabulary-prompt";
import { AuthoritiesPage } from "./authorities/authorities-page";
const ObjectNewPage = lazy(() => const ObjectNewPage = lazy(() =>
import("./objects/object-new-page").then((m) => ({ default: m.ObjectNewPage })), import("./objects/object-new-page").then((m) => ({ default: m.ObjectNewPage })),
@@ -54,6 +55,8 @@ export function App() {
<Route index element={<SelectVocabularyPrompt />} /> <Route index element={<SelectVocabularyPrompt />} />
<Route path=":id" element={<VocabularyTerms />} /> <Route path=":id" element={<VocabularyTerms />} />
</Route> </Route>
<Route path="/authorities" element={<Navigate to="/authorities/person" replace />} />
<Route path="/authorities/:kind" element={<AuthoritiesPage />} />
<Route path="/" element={<Navigate to="/objects" replace />} /> <Route path="/" element={<Navigate to="/objects" replace />} />
</Route> </Route>
</Route> </Route>
+102
View File
@@ -0,0 +1,102 @@
import { useState, type FormEvent } from "react";
import { NavLink, useParams } from "react-router-dom";
import { useTranslation } from "react-i18next";
import type { components } from "../api/schema";
import { useAuthorities, useCreateAuthority } from "../api/queries";
import { LabelEditor } from "../components/label-editor";
import { Button } from "@/components/ui/button";
type LabelInput = components["schemas"]["LabelInput"];
type LabelView = components["schemas"]["LabelView"];
const KINDS = ["person", "organisation", "place"] as const;
function labelText(labels: LabelView[], lang: string): string {
return (
labels.find((l) => l.lang === lang)?.label ??
labels.find((l) => l.lang === "en")?.label ??
labels[0]?.label ??
""
);
}
export function AuthoritiesPage() {
const { t, i18n } = useTranslation();
const { kind = "person" } = useParams();
const lang = i18n.language.startsWith("sv") ? "sv" : "en";
const { data: authorities } = useAuthorities(kind);
const create = useCreateAuthority();
const [labels, setLabels] = useState<LabelInput[]>([]);
const [error, setError] = useState(false);
const onCreate = (event: FormEvent) => {
event.preventDefault();
if (!labels.some((l) => l.lang === "en" && l.label)) {
setError(true);
return;
}
setError(false);
create.mutate(
{ kind, external_uri: null, labels },
{ onSuccess: () => setLabels([]) },
);
};
return (
<div className="overflow-auto p-4">
<div className="mb-3 flex gap-2">
{KINDS.map((k) => (
<NavLink
key={k}
to={`/authorities/${k}`}
className={({ isActive }) =>
`rounded px-3 py-1 text-sm ${isActive ? "bg-neutral-800 text-white" : "border"}`
}
>
{t(`authorities.${k}`)}
</NavLink>
))}
</div>
<ul className="mb-4">
{authorities?.length === 0 && (
<li className="text-sm text-neutral-500">{t("authorities.empty")}</li>
)}
{authorities?.map((a) => (
<li key={a.id} className="border-b py-1 text-sm">
{labelText(a.labels, lang)}
</li>
))}
</ul>
<form onSubmit={onCreate} className="space-y-2 border-t pt-3">
<div className="text-sm font-medium">
{t("authorities.new")} · {t(`authorities.${kind}`)}
</div>
<LabelEditor value={labels} onChange={setLabels} />
{error && (
<p role="alert" className="text-xs text-red-600">
{t("form.required")}
</p>
)}
{create.isError && (
<p role="alert" className="text-xs text-red-600">
{t("form.rejected")}
</p>
)}
<Button type="submit" size="sm" disabled={create.isPending}>
{t("authorities.create")}
</Button>
</form>
</div>
);
}
+37
View File
@@ -0,0 +1,37 @@
import { expect, test } from "vitest";
import { screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { http, HttpResponse } from "msw";
import { Routes, Route } from "react-router-dom";
import { server } from "../test/server";
import { renderApp } from "../test/render";
import { AuthoritiesPage } from "./authorities-page";
function tree() {
return (
<Routes>
<Route path="/authorities/:kind" element={<AuthoritiesPage />} />
</Routes>
);
}
test("lists authorities for the kind and creates one", async () => {
let body: unknown;
server.use(
http.post("/api/admin/authorities", async ({ request }) => {
body = await request.json();
return HttpResponse.json({ id: "a-c" }, { status: 201 });
}),
);
renderApp(tree(), { route: "/authorities/person" });
expect(await screen.findByText("Ada Lovelace")).toBeInTheDocument();
await userEvent.type(screen.getByLabelText(/label \(en\)/i), "Carl von Linné");
await userEvent.click(screen.getByRole("button", { name: /create/i }));
await waitFor(() => expect((body as { kind: string })?.kind).toBe("person"));
expect((body as { labels: { label: string }[] }).labels[0].label).toBe("Carl von Linné");
});
test("kind tabs link to the other kinds", async () => {
renderApp(tree(), { route: "/authorities/person" });
expect(await screen.findByRole("link", { name: /place/i })).toHaveAttribute("href", "/authorities/place");
});
+4
View File
@@ -14,6 +14,10 @@
"terms": "Terms", "addTerm": "Add term", "empty": "No vocabularies yet", "terms": "Terms", "addTerm": "Add term", "empty": "No vocabularies yet",
"noTerms": "No terms yet", "loadError": "Could not load" "noTerms": "No terms yet", "loadError": "Could not load"
}, },
"authorities": {
"title": "Authorities", "person": "Person", "organisation": "Organisation", "place": "Place",
"new": "New", "create": "Create", "empty": "No authorities yet", "loadError": "Could not load"
},
"publish": { "publish": {
"heading": "Visibility", "heading": "Visibility",
"advanceInternal": "Advance to internal", "advanceInternal": "Advance to internal",
+4
View File
@@ -14,6 +14,10 @@
"terms": "Termer", "addTerm": "Lägg till term", "empty": "Inga vokabulärer ännu", "terms": "Termer", "addTerm": "Lägg till term", "empty": "Inga vokabulärer ännu",
"noTerms": "Inga termer ännu", "loadError": "Kunde inte ladda" "noTerms": "Inga termer ännu", "loadError": "Kunde inte ladda"
}, },
"authorities": {
"title": "Auktoriteter", "person": "Person", "organisation": "Organisation", "place": "Plats",
"new": "Ny", "create": "Skapa", "empty": "Inga auktoriteter ännu", "loadError": "Kunde inte ladda"
},
"publish": { "publish": {
"heading": "Synlighet", "heading": "Synlighet",
"advanceInternal": "Gör intern", "advanceInternal": "Gör intern",
+9 -1
View File
@@ -5,7 +5,7 @@ import { useLogout } from "../api/queries";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { LangSwitch } from "./lang-switch"; import { LangSwitch } from "./lang-switch";
const DISABLED_NAV = ["authorities", "fields", "search"] as const; const DISABLED_NAV = ["fields", "search"] as const;
export function AppShell() { export function AppShell() {
const { t } = useTranslation(); const { t } = useTranslation();
@@ -38,6 +38,14 @@ export function AppShell() {
> >
{t("nav.vocabularies")} {t("nav.vocabularies")}
</NavLink> </NavLink>
<NavLink
to="/authorities"
className={({ isActive }) =>
`block rounded px-2 py-1 ${isActive ? "bg-neutral-200 font-medium" : ""}`
}
>
{t("nav.authorities")}
</NavLink>
{DISABLED_NAV.map((key) => ( {DISABLED_NAV.map((key) => (
<button <button
key={key} key={key}