feat(web): FlexibleFieldValue — resolve term/authority/localized field values (#45)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-06-07 11:32:17 +02:00
parent 7258b3fd03
commit 2e38af565a
5 changed files with 222 additions and 2 deletions
@@ -0,0 +1,62 @@
import type { Meta, StoryObj } from '@storybook/react-vite'
import { expect } from 'storybook/test'
import { FlexibleFieldValue } from './flexible-field-value'
import { fieldDefinitions } from '../test/fixtures'
const def = (key: string) => fieldDefinitions.find((d) => d.key === key)!
const meta = {
component: FlexibleFieldValue,
tags: ['ai-generated'],
} satisfies Meta<typeof FlexibleFieldValue>
export default meta
type Story = StoryObj<typeof meta>
export const Term: Story = {
args: { def: def('material'), value: 't-bronze', lang: 'en' },
play: async ({ canvas }) => {
await expect(await canvas.findByText('Bronze')).toBeVisible()
},
}
export const Authority: Story = {
args: { def: def('maker'), value: 'a-ada', lang: 'en' },
play: async ({ canvas }) => {
await expect(await canvas.findByText('Ada Lovelace')).toBeVisible()
},
}
export const LocalizedText: Story = {
args: {
def: def('title_ml'),
value: { sv: 'Brons-amfora', en: 'Bronze amphora' },
lang: 'sv',
},
play: async ({ canvas }) => {
await expect(canvas.getByText('Brons-amfora')).toBeVisible()
},
}
export const Date: Story = {
args: { def: def('made_on'), value: '2024-01-05', lang: 'en' },
play: async ({ canvas }) => {
await expect(canvas.queryByText('2024-01-05')).not.toBeInTheDocument()
await expect(canvas.getByText(/Jan.*5.*2024/)).toBeVisible()
},
}
export const Boolean: Story = {
args: { def: def('is_fragment'), value: true, lang: 'en' },
play: async ({ canvas }) => {
await expect(canvas.getByText('Yes')).toBeVisible()
},
}
export const UnknownRef: Story = {
args: { def: def('material'), value: 't-missing', lang: 'en' },
play: async ({ canvas }) => {
await expect(await canvas.findByText(/t-missing\s*\(unknown\)/)).toBeVisible()
},
}
@@ -0,0 +1,54 @@
import { expect, test } from "vitest";
import { screen } from "@testing-library/react";
import { renderApp } from "../test/render";
import { FlexibleFieldValue } from "./flexible-field-value";
import { fieldDefinitions } from "../test/fixtures";
function def(key: string) {
return fieldDefinitions.find((d) => d.key === key)!;
}
test("term id resolves to its label", async () => {
renderApp(<FlexibleFieldValue def={def("material")} value="t-bronze" lang="en" />);
expect(await screen.findByText("Bronze")).toBeInTheDocument();
});
test("authority id resolves to its label", async () => {
renderApp(<FlexibleFieldValue def={def("maker")} value="a-ada" lang="en" />);
expect(await screen.findByText("Ada Lovelace")).toBeInTheDocument();
});
test("unknown term id renders <id> (unknown)", async () => {
renderApp(<FlexibleFieldValue def={def("material")} value="t-missing" lang="en" />);
expect(await screen.findByText(/t-missing\s*\(unknown\)/)).toBeInTheDocument();
});
test("localized_text picks the active language string", () => {
renderApp(
<FlexibleFieldValue
def={def("title_ml")}
value={{ sv: "Brons-amfora", en: "Bronze amphora" }}
lang="sv"
/>,
);
expect(screen.getByText("Brons-amfora")).toBeInTheDocument();
expect(screen.queryByText("Bronze amphora")).not.toBeInTheDocument();
});
test("date is formatted, not the raw ISO string", () => {
renderApp(<FlexibleFieldValue def={def("made_on")} value="2024-01-05" lang="en" />);
expect(screen.queryByText("2024-01-05")).not.toBeInTheDocument();
expect(screen.getByText(/Jan.*5.*2024/)).toBeInTheDocument();
});
test("boolean true renders Yes", () => {
renderApp(<FlexibleFieldValue def={def("is_fragment")} value={true} lang="en" />);
expect(screen.getByText("Yes")).toBeInTheDocument();
});
+102
View File
@@ -0,0 +1,102 @@
import { useTranslation } from "react-i18next";
import type { components } from "../api/schema";
import { useTerms, useAuthorities } from "../api/queries";
import { labelText } from "../lib/labels";
type FieldDefinitionView = components["schemas"]["FieldDefinitionView"];
/** Renders one flexible field value as human-readable text, resolving term/authority ids
* to labels and localized_text to the active language. */
export function FlexibleFieldValue({
def,
value,
lang,
}: {
def: FieldDefinitionView;
value: unknown;
lang: string;
}) {
switch (def.data_type) {
case "term":
return <TermValue vocabularyId={def.vocabulary_id ?? null} value={value} lang={lang} />;
case "authority":
return <AuthorityValue kind={def.authority_kind ?? null} value={value} lang={lang} />;
case "localized_text":
return <>{pickLocalized(value, lang)}</>;
case "date":
return <>{formatDate(value, lang)}</>;
case "boolean":
return <BooleanValue value={value} />;
default:
return <>{value == null ? "—" : String(value)}</>;
}
}
function TermValue({
vocabularyId,
value,
lang,
}: {
vocabularyId: string | null;
value: unknown;
lang: string;
}) {
const { t } = useTranslation();
const { data: terms, isLoading } = useTerms(vocabularyId ?? undefined);
if (typeof value !== "string") return <></>;
const term = terms?.find((x) => x.id === value);
if (term) return <>{labelText(term.labels, lang)}</>;
if (isLoading) return <span className="text-neutral-400"></span>;
return (
<span className="text-neutral-400">
{value} {t("objects.unknownRef")}
</span>
);
}
function AuthorityValue({
kind,
value,
lang,
}: {
kind: string | null;
value: unknown;
lang: string;
}) {
const { t } = useTranslation();
const { data: authorities, isLoading } = useAuthorities(kind ?? undefined);
if (typeof value !== "string") return <></>;
const authority = authorities?.find((x) => x.id === value);
if (authority) return <>{labelText(authority.labels, lang)}</>;
if (isLoading) return <span className="text-neutral-400"></span>;
return (
<span className="text-neutral-400">
{value} {t("objects.unknownRef")}
</span>
);
}
function BooleanValue({ value }: { value: unknown }) {
const { t } = useTranslation();
return <>{value ? t("common.yes") : t("common.no")}</>;
}
function pickLocalized(value: unknown, lang: string): string {
if (value && typeof value === "object" && !Array.isArray(value)) {
const map = value as Record<string, string>;
return map[lang] ?? map.en ?? Object.values(map)[0] ?? "—";
}
return value == null ? "—" : String(value);
}
/** Formats a date-only ISO string (YYYY-MM-DD) for display in the active locale.
* Parses as local midnight so a date-only value isn't shifted a day by tz. */
export function formatDate(value: unknown, lang: string): string {
if (typeof value !== "string") return value == null ? "—" : String(value);
const date = new Date(`${value}T00:00:00`);
if (Number.isNaN(date.getTime())) return value;
return new Intl.DateTimeFormat(lang, { dateStyle: "medium" }).format(date);
}